Define is(read|writ)able for BufferStream.#6
Open
fredrikekre wants to merge 4 commits intoJuliaPackaging:masterfrom
Open
Define is(read|writ)able for BufferStream.#6fredrikekre wants to merge 4 commits intoJuliaPackaging:masterfrom
fredrikekre wants to merge 4 commits intoJuliaPackaging:masterfrom
Conversation
Member
Author
|
CI on travis was stalled so switched to GH actions but that doesn't run since this PR is from a branch |
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
==========================================
+ Coverage 95.55% 96.73% +1.18%
==========================================
Files 2 2
Lines 90 92 +2
==========================================
+ Hits 86 89 +3
+ Misses 4 3 -1
Continue to review full report at Codecov.
|
fingolfin
approved these changes
May 17, 2023
Member
fingolfin
left a comment
fingolfin
left a comment
There was a problem hiding this comment.
This seems plausible to me, but of course the CI tests are still useless right now...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.