Allow specifying a Rust and Go toolchain version for the build #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please bump the minor version of this package so that we can tag it and then require that version in JuliaPackaging/BinaryBuilder.jl#1358 for consistency? Looks good to me otherwise, this is pretty much what I was expecting (well, even more than I was thinking). |
|
Version bumped. |
giordano
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes two new keyword arguments for finding the shards:
preferred_rust_versionandpreferred_go_version, which will specify the version of the toolchain to use. Note these are implemented as strict requests for now, but I kept the "preferred" name to match the gcc and llvm arguments.I know the Rust toolchain is probably fine as a strict request, but I don't know about Go's commitment to compatibility across compiler versions.