Remove .pkg if no longer augmenting
#1383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may point to a larger issue, we should perhaps remove the content of the git repository before regenerating the files. |
Uhm, that'd break the case where we call build_tarballs multiple times. |
vchuravy
commented
May 14, 2025
giordano
approved these changes
May 16, 2025
Co-authored-by: Mosè Giordano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@maleadt removed augmentation recently from pocl_jll
JuliaBinaryWrappers/pocl_jll.jl@cfcdb23
But the
.pkgdir remained confusing things down the road.