Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add beta binomial distribution #234

Merged
merged 4 commits into from
Aug 30, 2022
Merged

add beta binomial distribution #234

merged 4 commits into from
Aug 30, 2022

Conversation

nignatiadis
Copy link
Contributor

A short PR that implements the BetaBinomial distribution. This is needed for #226, but the PR should be self-contained.

I tried to follow the code for Binomial but am not sure about some things (especially rand having a separate signature withTuple{I,A}}) where {I<:Integer,A}).

@github-actions
Copy link
Contributor

Package name latest stable
Mitosis.jl
Soss.jl

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #234 (d9a0bf9) into master (6a42ef6) will increase coverage by 0.62%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
+ Coverage   44.60%   45.23%   +0.62%     
==========================================
  Files          42       43       +1     
  Lines        1307     1322      +15     
==========================================
+ Hits          583      598      +15     
  Misses        724      724              
Impacted Files Coverage Δ
src/MeasureTheory.jl 50.00% <ø> (ø)
src/parameterized/betabinomial.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

Package name latest stable
Mitosis.jl
Soss.jl

Copy link
Collaborator

@cscherrer cscherrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nignatiadis ! I pushed a commit running JuliaFormatter, and added a suggestion for rand. Unless there's an efficiency benefit to going through Distributions, this seems pretty clean to me. Let me know what you think :)

src/parameterized/betabinomial.jl Outdated Show resolved Hide resolved
src/parameterized/betabinomial.jl Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Package name latest stable
Mitosis.jl
Soss.jl

@nignatiadis
Copy link
Contributor Author

Thank you @cscherrer. Definitely makes sense to code it directly (and in fact, that's exactly the implementation in Distributions.jl).

@cscherrer
Copy link
Collaborator

Is there anything using proxy for this case? If nothing calls it let's leave it out until we need it. Then we need to bump the version and should be good to go

@nignatiadis
Copy link
Contributor Author

Just removed proxy and bumped the version!

@github-actions
Copy link
Contributor

Package name latest stable
Mitosis.jl
Soss.jl

Copy link
Collaborator

@cscherrer cscherrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks again @nignatiadis

@cscherrer cscherrer merged commit 5311dff into master Aug 30, 2022
@cscherrer cscherrer deleted the ni-betabinomial branch August 30, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants