-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add beta binomial distribution #234
Conversation
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
+ Coverage 44.60% 45.23% +0.62%
==========================================
Files 42 43 +1
Lines 1307 1322 +15
==========================================
+ Hits 583 598 +15
Misses 724 724
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nignatiadis ! I pushed a commit running JuliaFormatter, and added a suggestion for rand
. Unless there's an efficiency benefit to going through Distributions, this seems pretty clean to me. Let me know what you think :)
Co-authored-by: Chad Scherrer <[email protected]>
Thank you @cscherrer. Definitely makes sense to code it directly (and in fact, that's exactly the implementation in Distributions.jl). |
Is there anything using |
Just removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks again @nignatiadis
A short PR that implements the BetaBinomial distribution. This is needed for #226, but the PR should be self-contained.
I tried to follow the code for
Binomial
but am not sure about some things (especiallyrand
having a separate signature withTuple{I,A}}) where {I<:Integer,A})
.