-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc adjustments #169
Doc adjustments #169
Conversation
@gdalle Here’s my go through of the affine transform doc page. I’m new to the material so I may have introduced factual errors in pursuit of simplifying / adjusting. I defer to your judgement as to what to keep / what to skip. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jeremiahpslewis ! I've made a few comments, and I'd also like @gdalle's thoughts on this before we merge
Co-authored-by: Chad Scherrer <[email protected]>
Co-authored-by: Chad Scherrer <[email protected]>
Co-authored-by: Chad Scherrer <[email protected]>
@cscherrer Thanks for the review, I went ahead and added your suggestions and made a few further tweaks based on the direction of your feedback. Looking forward to hearing from @gdalle :) |
Co-authored-by: Moritz Schauer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mainly spotted minor typos, but a more important comment would be the name Affine
: why not AffineMeasure
?
We'll definitely have some things with |
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
==========================================
- Coverage 45.31% 45.07% -0.25%
==========================================
Files 32 32
Lines 673 670 -3
==========================================
- Hits 305 302 -3
Misses 368 368
Continue to review full report at Codecov.
|
Do we really have to issue a new release for such small, docs-only changes @cscherrer? |
Not critical, but also not much reason not to have a minor release. They're free and pretty easy 🙂 |
The one reason I see it could be nice is so people are more likely to see the new version of the docs |
No description provided.