Skip to content

Use StaticInteger instead of StaticInt and add tests for static util functions #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2023

Conversation

oschulz
Copy link
Collaborator

@oschulz oschulz commented May 30, 2023

Follow-up to #115 .

We should use StaticInteger instead of StaticInt for argument types.

Also adds tests for the new functions in static.jl.

@oschulz oschulz requested a review from cscherrer May 30, 2023 17:24
@github-actions
Copy link

Package name latest stable
MeasureTheory.jl

@github-actions
Copy link

Package name latest stable
MeasureTheory.jl

@oschulz
Copy link
Collaborator Author

oschulz commented May 30, 2023

Tests fixed.

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.24 🎉

Comparison is base (5bba40f) 53.80% compared to head (4dac4fc) 54.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   53.80%   54.05%   +0.24%     
==========================================
  Files          43       43              
  Lines        1221     1221              
==========================================
+ Hits          657      660       +3     
+ Misses        564      561       -3     
Impacted Files Coverage Δ
src/MeasureBase.jl 77.77% <ø> (ø)
src/density-core.jl 76.66% <ø> (ø)
src/utils.jl 47.29% <0.00%> (ø)
src/standard/stdmeasure.jl 91.30% <100.00%> (ø)
src/static.jl 80.00% <100.00%> (+20.00%) ⬆️
src/transport.jl 75.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@theogf theogf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it just needs a version bump

@oschulz
Copy link
Collaborator Author

oschulz commented May 31, 2023

Added version bump.

@github-actions
Copy link

Package name latest stable
MeasureTheory.jl

@theogf theogf merged commit 7cb87d5 into master May 31, 2023
@theogf theogf deleted the static-integer branch May 31, 2023 10:39
@oschulz
Copy link
Collaborator Author

oschulz commented May 31, 2023

Merci @theogf !

@oschulz
Copy link
Collaborator Author

oschulz commented May 31, 2023

Next on the agenda will the polishing up the transport framework and turning DistributionMeasures.jl into a MeasureBase.jl Pkg-extension (DistributionMeasures.jl itself will become deprecated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants