Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test with [1.3, lts, 1] #143

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

inkydragon
Copy link
Member

@inkydragon inkydragon commented Dec 14, 2024

  • test with [1.3, lts, 1]
    compat require julia >= v1.3
    julia = "1.3.0"
  • test with macos-13-x64 and macos-latest-aarch64
  • fix julia compat with < v1.5

@inkydragon
Copy link
Member Author

empty intersection between [email protected] and project compatibility 1.3.0-1

At the moment we can't upgrade stdlib on its own, so perhaps just limiting the version of julia would be enough.

https://discourse.julialang.org/t/compat-bounds-for-stdlib-and-empty-intersection-issue-on-ci/105898

@inkydragon
Copy link
Member Author

inkydragon commented Dec 14, 2024

Seems to need a compact upgrade

ERROR: LoadError: LoadError: UndefVarError: ismutable not defined

@assert ismutable(gsl_function(C_NULL, C_NULL))

help?> ismutable
search: ismutable isimmutable iswritable ismutabletype isexecutable isreadable showable displayable Base.ImmutableDict

  ismutable(v) -> Bool

...

  │ Julia 1.5
  │
  │  This function requires at least Julia 1.5.

@inkydragon inkydragon marked this pull request as ready for review December 14, 2024 04:44
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.93%. Comparing base (ee43384) to head (6211ee2).

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #143      +/-   ##
=========================================
+ Coverage    6.87%   6.93%   +0.05%     
=========================================
  Files         189     189              
  Lines        9930    9936       +6     
=========================================
+ Hits          683     689       +6     
  Misses       9247    9247              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant