Skip to content

Conversation

nHackel
Copy link

@nHackel nHackel commented Sep 3, 2025

This PR adds a backend token api as discussed in this AbstractFFTs PR. It would be great if we could keep the main discussion on the general design in the AbstractFFT PR.

Such an API would close #66.

@dannys4
Copy link
Collaborator

dannys4 commented Sep 3, 2025

@nHackel this is great, and I think significantly better than my (unfortunately forgotten) fix #67 . Ping me when the AbstractFFTs PR goes through and I'd be happy to merge this, pending tests passing.

@nHackel
Copy link
Author

nHackel commented Sep 4, 2025

@dannys4 Here is a version of the backend variant which solely relies on the backend token and thus results in a breaking change. To not spam PRs, I created a PR in my fork for now.

@dannys4
Copy link
Collaborator

dannys4 commented Sep 4, 2025

looks good, seems to work on my machine when I check out your branches. Feel free to just include all changes in one pr and ping me when the AbstractFFTs changes get made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FFTA.plan_fft returns an FFTW plan if both FFTW and FFTA are used

2 participants