Skip to content

Bugfix: include empty combination #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 10, 2025
Merged

Bugfix: include empty combination #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7dc8fb6
Add files via upload
Stivanification Jan 5, 2017
d6c132a
Merge pull request #1 from Stivanification/Add-vector_partitions-method
Stivanification Jan 5, 2017
19ef327
Update comment formatting in vector_partitions.jl
Stivanification Feb 13, 2017
3c839a4
Merge branch 'JuliaMath:master' into master
Stivanification Dec 25, 2022
7ceb259
bugfix: include empty combination, update tests
Dec 26, 2022
df85dee
Merge branch 'master' into bugfix_include_empty_combination
inkydragon May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/combinations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,7 @@ end
Generate combinations of the elements of `a` of all orders. Chaining of order iterators
is eager, but the sequence at each order is lazy.
"""
combinations(a) = Iterators.flatten([combinations(a, k) for k = 1:length(a)])


combinations(a) = Iterators.flatten([combinations(a, k) for k = 0:length(a)])

# cool-lex combinations iterator

Expand Down
5 changes: 3 additions & 2 deletions test/combinations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
@testset "combinations" begin
@test [combinations([])...] == []
@test [combinations(['a', 'b', 'c'])...] == [['a'], ['b'], ['c'], ['a', 'b'], ['a', 'c'], ['b', 'c'], ['a', 'b', 'c']]
@test [combinations([])...] == [[]]
@test [combinations(['a', 'b', 'c'])...] == [[],['a'],['b'],['c'],['a','b'],['a','c'],['b','c'],['a','b','c']]
@test length(collect(combinations(1:5))) == 32

@test [combinations("abc", 3)...] == [['a', 'b', 'c']]
@test [combinations("abc", 2)...] == [['a', 'b'], ['a', 'c'], ['b', 'c']]
Expand Down
Loading