Skip to content

Linear algebra type stability enhancements and matrix solve support#132

Merged
krasow merged 15 commits into
developfrom
solve
Jun 2, 2026
Merged

Linear algebra type stability enhancements and matrix solve support#132
krasow merged 15 commits into
developfrom
solve

Conversation

@Nader-Rahhal
Copy link
Copy Markdown
Collaborator

@Nader-Rahhal Nader-Rahhal commented May 20, 2026

related Legate PR: JuliaLegate/Legate.jl#84
Currently uses 1 gpu

requires legate_branch: develop

@Nader-Rahhal Nader-Rahhal requested a review from krasow May 20, 2026 18:00
Comment thread src/ndarray/linalg.jl Outdated
@krasow krasow changed the base branch from main to develop May 31, 2026 19:00
@krasow
Copy link
Copy Markdown
Member

krasow commented Jun 1, 2026

@Nader-Rahhal I got the tests passing in CI; however, we need to expand the tests to encapsulate all supported types for solve and the lin alg test suite. Basically adding a for T in SUPPORTED_NUMERIC_TYPES (or being more restrictive for things that fail in solve) over the test case.

@Nader-Rahhal
Copy link
Copy Markdown
Collaborator Author

@Nader-Rahhal I got the tests passing in CI; however, we need to expand the tests to encapsulate all supported types for solve and the lin alg test suite. Basically adding a for T in SUPPORTED_NUMERIC_TYPES (or being more restrictive for things that fail in solve) over the test case.

Sounds good. I can get this implemented tomorrow.

@Nader-Rahhal
Copy link
Copy Markdown
Collaborator Author

@krasow I added the type coverage. For all types that arent FP and Complex, cupynumeric casts to f64 so we just copy that

@krasow
Copy link
Copy Markdown
Member

krasow commented Jun 1, 2026

@Nader-Rahhal You should use one of the predefined consts (defined in src/cuNumeric.jl) instead of listing out everything. Additionally, you can enable verbose=true on the testset so it prints out by T pass/fail.

@krasow
Copy link
Copy Markdown
Member

krasow commented Jun 2, 2026

I removed the as_type conversions to get solve passing for integer types. We can not support ints on solve. Or we can do an implicit type conversion to floats.

@krasow krasow changed the title matrix solve Linear algebra type stability enhancements and matrix solve support Jun 2, 2026
@krasow krasow merged commit 97dc5f5 into develop Jun 2, 2026
7 of 8 checks passed
@krasow krasow deleted the solve branch June 2, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants