-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce AnnotatedIOBuffer #51807
Merged
Merged
Introduce AnnotatedIOBuffer #51807
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2730f29
Introduce AnnotatedIOBuffer
tecosaur 311553e
Make AnnotatedIOBuffer behave more like IOBuffer
tecosaur c2b441b
Make AnnotatedIOBuffer reading more generic
tecosaur f4c5e13
Also read AnnotatedChars from an AnnotatedIOBuffer
tecosaur d49ba4f
Writing from one AnnotatedIOBuffer to another
tecosaur 2e6ebb9
Tests for AnnotatedIOBuffer
tecosaur 39839ac
Update the mention of annotated features in NEWS
tecosaur 2b9839b
Use insert! not splice! for new annotations
tecosaur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not to hold up this PR, but do you think we should add these to AbstractPipe also (all on the read side), except
copy
which doesn't have a generic implementation, or is it too much ambiguous whether this intends to attempt to manipulate the reader or writer halfThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a slightly tricky one I think. I've found the lack of
position
andseek
annoying withIOContext
-wrappedIOBuffer
s myself, however I think the problem is that sometimes IO has a read-head and a write-head, and sometimes it doesn't.I think the cleaner way for this to be implemented is to have read-head and write-head variants of
position
/seek
/etc. and if needed have them refer to the same head for IO types where there can only be one head. However, instead the default assumption is that they are the same, and so the model falls short as soon as there is distinct input and output IO.