Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Improved (?) tab completion for symbols #26445

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mpastell
Copy link
Contributor

This changes the REPL to show latex and emoji symbols as tab completions and complete names starting with that symbol as well:

symb_repl

This a very initial to implementation to get some feedback whether this is a good idea at all. See some discussion at: JuliaLang/IJulia.jl#634

@JeffBezanson
Copy link
Member

I don't like this because I want to know what I can actually type, not just what characters are available. We could potentially show both what to type and what the resulting character would look like.

I don't think we should complete both character names and full identifiers at once. It doesn't make sense to suggest α1 if we don't yet know whether you want to type an alpha.

@mpastell
Copy link
Contributor Author

I actually also think that showing full completions makes more sense in Jupyter as there you can choose the completion from a menu.

@JeffBezanson
Copy link
Member

That's true, but I think even there I'd also like to see the character name so I know what to type in the future.

@mpastell
Copy link
Contributor Author

I'd be happy with adding character preview to the REPL and using JuliaLang/IJulia.jl#634 for IJulia.

I'm not sure how I could add the character names to Jupyter completetions, I think it would require changes in Jupyter protocol. @stevengj any thoughts? In Jupyter lab this could be added to completer metadata, but at least currently the colors of compeletions would be messed up.

@ChristianKurz
Copy link
Contributor

This could be improved by using a TerminalMenu for tab-completion.

It would be nice to have a multi-column terminal menu for that, though.

@KristofferC
Copy link
Member

The IPython preview is nice:

screen shot 2018-03-14 at 10 34 26

@StefanKarpinski
Copy link
Member

Having graphical selection for tab completion would be ideal. As @ChristianKurz said, we've got all the bits and pieces now that TerminalMenus is included in the REPL code, we just need to integrate it and iterate on the features more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants