Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for newline handling and fix support for windows. #16

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

LilithHafner
Copy link
Member

@LilithHafner LilithHafner commented Oct 26, 2023

Should fix windows CI.
Waiting to push the fix till CI fails with the tests.
Closes #14 which was, in comparison to this, mucking around in the dark waiting for the lights to turn green.

@LilithHafner
Copy link
Member Author

LilithHafner commented Oct 26, 2023

Ubunto nightly failed with a failure in the styled macro testset as expected (on 220bb5d)

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #16 (9f29260) into main (63ff132) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   67.21%   67.33%   +0.12%     
==========================================
  Files           7        7              
  Lines         796      799       +3     
==========================================
+ Hits          535      538       +3     
  Misses        261      261              
Files Coverage Δ
src/stylemacro.jl 71.69% <100.00%> (+0.26%) ⬆️

@LilithHafner
Copy link
Member Author

And now all nightly tests pass! :)

@tecosaur tecosaur merged commit b7fca5b into main Oct 26, 2023
@tecosaur tecosaur deleted the lh/newline branch October 26, 2023 17:54
@tecosaur
Copy link
Collaborator

Hmmm, I'm not sure we should actually test Julia's parsing of \<newline>.

normal = "abc\
def"
styled = styled"abc\
def"
@test normal == styled == "abcdef"
normal = "abc\\ndef"
styled = styled"abc\\ndef"
@test normal == styled == "abc\\ndef"
normal = eval(Meta.parse("\"abc\\\n \tdef\""))
styled = eval(Meta.parse("styled\"abc\\\n \tdef\""))
@test normal == styled == "abcdef"
normal = eval(Meta.parse("\"abc\\\r\n def\""))
styled = eval(Meta.parse("styled\"abc\\\r\n def\""))
@test normal == styled == "abcdef"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants