Explicit that calls to external methods should be traced back to MyPackage#43
Merged
timholy merged 3 commits intoJuliaLang:mainfrom Apr 2, 2025
Merged
Explicit that calls to external methods should be traced back to MyPackage#43timholy merged 3 commits intoJuliaLang:mainfrom
timholy merged 3 commits intoJuliaLang:mainfrom
Conversation
timholy
reviewed
Mar 18, 2025
Member
timholy
left a comment
There was a problem hiding this comment.
Thanks, this is indeed helpful.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
- Coverage 91.66% 81.81% -9.85%
==========================================
Files 3 3
Lines 96 77 -19
==========================================
- Hits 88 63 -25
- Misses 8 14 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Many thanks @serenity4 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help users avoid issues when directly precompiling methods they don't own in their Startup package.
I also changed
@snoopi_deepto@snoop_inferenceand@snooprto@snoop_invalidations, I think those were leftovers from JuliaDebug/SnoopCompile.jl#386.