Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzzy completions #962

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented Nov 18, 2020

This PR provides a way to get fuzzy completions from IJulia kernel.

Fuzzy completions are useful in those frontends where some richer UIs to show candidates are available, and I think most of Jupyter frontends suit for that, e.g.:
image

Users can opt-in fuzzy completion mode by installkernel(...; fuzzy_completion_mode = true) and then FuzzyCompletions.jl will provide completions as a drop-in replacement of the REPL.REPLCompletions module.

@twavv
Copy link
Contributor

twavv commented Nov 18, 2020

Won't this cause weird issues because fuzzycompletions isn't in the project.toml?

@aviatesk
Copy link
Member Author

It is in Project.toml, no ?

FuzzyCompletions = "fb4132e2-a121-4a70-b8a1-d5b831dcdcc2"

@twavv
Copy link
Contributor

twavv commented Nov 19, 2020

Ah sorry, it is. I must have missed it.

I do wish there was a better way to do "optional" dependencies in Julia though

@aviatesk
Copy link
Member Author

well, just as for FuzzyCompletions, it's really light weight and so I don't think this dependency could be any problem.

@stevengj
Copy link
Member

It would be better to have a plug-in architecture for completions (ideally in the underlying REPL.REPLCompletions stdlib), so that users can just put using FuzzyCompletions in their startup file and it will use it.

@MasonProtter
Copy link
Contributor

Now that we have package extensions, and weak deps, could we revive this?

@stevengj
Copy link
Member

A package extension seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants