Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter messaging updates/correctness #1138

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

halleysfifthinc
Copy link
Contributor

  • Bump Julia compat to be able to use pkgversion in "kernel_info_request" to report the IJulia version
  • Some messages and responses were sent on the wrong channel:
    • Replies should be sent to the channel the request was sent on
      • This is not 💯 explicit in the messaging protocol docs, but appears to be the norm. Some messages are only described as always being sent (by the frontend/client) on a specific channel, but e.g. I saw "kernel_info_request" sent on both the shell/requests channel AND the control channel. (The latter is not described as possible according to the docs.)
  • Replies should always have a { 'status': 'ok' }
  • The transient metadata field was added in protocol version 5.1. Without the ability to add transient metadata, "update_display_data" messages can't be used to update/redisplay existing outputs (while participating in/with the rest of the IJulia display machinery). Related PR Function to publish raw/encoded display data #946 is more extensive and stalled; this is the minimum necessary change to support this.

Fixes #953
Fixes #1000

Reference: https://jupyter-client.readthedocs.io/en/latest/messaging.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant