register atexit hook on module _init_#242
Open
sjkelly wants to merge 1 commit intoJuliaLang:masterfrom
Open
Conversation
These hooks are usually registered at module `_init_`, partially to make the code easier to reason about. Though this now has greater significance with improved static compilation techniques, since the _init_ is the module entry and anything outside will be discarded from what I can tell.
Member
|
Yeah that makes sense. The previous behavior feels broken... |
Member
|
@sjkelly Are you still interested in moving this PR forward? If so, can you rebase on the latest master, and fix the merge conflicts? I will then try to recruit someone to review this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These hooks are usually registered at module
__init__,partially to make the code easier to reason about. Though
this now has greater significance with improved static
compilation techniques, since the
__init__is the moduleentry and anything outside will be discarded from what
I can tell.