Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next] WebIO v1.0 #371

Closed
wants to merge 11 commits into from
Closed

[Next] WebIO v1.0 #371

wants to merge 11 commits into from

Conversation

twavv
Copy link
Member

@twavv twavv commented Dec 22, 2019

See #368

@twavv
[Next] Update for JSExpr v1.0. (#369)
d983987 
* Update for JSExpr v1.0.

* Update Project.toml.

* Skip Blink tests for now.

* Remove Blink from docs.

* Don't re-export @js macro from JSExpr.
@codecov
Copy link

codecov bot commented Dec 22, 2019 •
edited
Loading

Codecov Report

Merging #371 into master will decrease coverage by 13.50%.
The diff coverage is 47.59%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #371       +/-   ##
===========================================
- Coverage   62.10%   48.59%   -13.51%     
===========================================
  Files          16       19        +3     
  Lines         599      605        +6     
===========================================
- Hits          372      294       -78     
- Misses        227      311       +84
Impacted Files Coverage Δ
src/WebIO.jl 76.47% <ø> (-1.31%) ⬇️
src/syntax.jl 81.48% <ø> (-12.11%) ⬇️
src/observables.jl 32.25% <32.25%> (ø)
src/scope.jl 37.80% <41.93%> (-27.68%) ⬇️
src/connectionpool.jl 46.34% <46.34%> (ø)
src/messaging.jl 37.09% <48.83%> (+14.87%) ⬆️
src/providers/generic_http.jl 64.17% <62.50%> (-8.90%) ⬇️
src/evaljs.jl 80.00% <80.00%> (ø)
src/jsexpr.jl 85.71% <85.71%> (ø)
src/rpc.jl 100.00% <100.00%> (+100.00%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4748f0...3c5a856. Read the comment docs.

@shashi
Copy link
Member

shashi commented Dec 22, 2019

Separate PR for each feature?

@twavv
Copy link
Member Author

twavv commented Dec 22, 2019

Separate PR for each feature?

Yeah I was planning on that to make things manageable while still keeping master usable if we need to make other changes.

@twavv
Re-work messaging interface. (#372)
ccc74da 
* Use Val-based dispatch for handling commands in Julia.

* Start reworking request/response stuff (and update RPC); TypeScript not done yet.

* Add some documentation on messaging and IJulia messaging issues.

* Change command/request sending machinery.

* Fix CI (restrict to Julia 1.0+)

* Update messaging to consistently use payload field.

* Implement modified evaljs.

* Implement synchronous message sending.

* Disallow sending requests to ConnectionPools.
This was referenced Dec 26, 2019
Closed
Closed
@aminya
Copy link

aminya commented Jan 5, 2020 •
edited
Loading

This seems like a huge PR. 😄.

I want to add some features from WebIO into my package AcuteML. Things like "External frontend interfaces" and "JavaScript interface" can be used for AcuteML too. Also, I want to allow users to use a mix of WebIO and AcuteML, so a solid AcuteML <-> WebIO interface would be needed.

I should observe this PR to see what changes.

@shashi
Copy link
Member

shashi commented Jan 8, 2020

Yeah I was planning on that to make things manageable while still keeping master usable if we need to make other changes.

Yes please!

@twavv twavv closed this Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twavv @shashi @aminya