Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add official support for Frustum, Pyramid, and Wedge geometries #168

Merged
merged 18 commits into from
Feb 19, 2025

Conversation

mikeingold
Copy link
Collaborator

@mikeingold mikeingold commented Feb 19, 2025

Changed

  • Adds official support for Frustum, Pyramid, and Wedge geometries.
    • Adds unit tests for all three types
    • Updates support matrix status for all three types

Ref: https://github.com/JuliaGeometry/Meshes.jl/releases/tag/v0.52.12

@mikeingold mikeingold added the enhancement New feature or request label Feb 19, 2025
@mikeingold mikeingold self-assigned this Feb 19, 2025
Copy link
Contributor

github-actions bot commented Feb 19, 2025

Benchmark Results

main c21b941... main/c21b941f387f66...
Differentials/Differential 0.202 ± 0.001 μs 0.203 ± 0.001 μs 0.995
Differentials/Jacobian 0.167 ± 0.001 μs 0.167 ± 0.001 μs 0.999
Integrals/Segment/Scalar GaussKronrod 0.548 ± 0.0057 μs 0.548 ± 0.0052 μs 1
Integrals/Segment/Scalar GaussLegendre 1.65 ± 0.0081 μs 1.61 ± 0.007 μs 1.03
Integrals/Segment/Scalar HAdaptiveCubature 0.686 ± 0.0087 μs 0.725 ± 0.015 μs 0.946
Integrals/Segment/Vector GaussKronrod 2.7 ± 0.075 μs 2.75 ± 0.091 μs 0.983
Integrals/Segment/Vector GaussLegendre 18 ± 0.49 μs 17.6 ± 0.66 μs 1.02
Integrals/Segment/Vector HAdaptiveCubature 3.54 ± 0.078 μs 3.59 ± 0.12 μs 0.986
Integrals/Sphere/Scalar GaussKronrod 0.0673 ± 0.00084 ms 0.0674 ± 0.00046 ms 0.999
Integrals/Sphere/Scalar GaussLegendre 1.83 ± 0.0028 ms 1.83 ± 0.0034 ms 0.998
Integrals/Sphere/Scalar HAdaptiveCubature 0.0468 ± 0.00012 ms 0.0477 ± 0.00017 ms 0.982
Integrals/Sphere/Vector GaussKronrod 0.101 ± 0.0013 ms 0.102 ± 0.0017 ms 0.988
Integrals/Sphere/Vector GaussLegendre 3.22 ± 0.067 ms 3.31 ± 0.086 ms 0.974
Integrals/Sphere/Vector HAdaptiveCubature 0.0971 ± 0.0015 ms 0.0983 ± 0.0021 ms 0.987
Rules/GaussLegendre 22.1 ± 0.53 μs 22.2 ± 0.55 μs 0.997
Specializations/Scalar GaussLegendre/BezierCurve 0.252 ± 0.0069 ms 0.245 ± 0.0074 ms 1.03
Specializations/Scalar GaussLegendre/Line 7.21 ± 0.066 μs 7.01 ± 0.086 μs 1.03
Specializations/Scalar GaussLegendre/Plane 0.745 ± 0.0017 ms 0.744 ± 0.0015 ms 1
Specializations/Scalar GaussLegendre/Ray 5.79 ± 0.045 μs 5.88 ± 0.057 μs 0.984
Specializations/Scalar GaussLegendre/Rope 0.0507 ± 0.0002 ms 0.0505 ± 0.00019 ms 1
Specializations/Scalar GaussLegendre/Tetrahedron 0.156 ± 0.0017 s 0.158 ± 0.0021 s 0.985
Specializations/Scalar GaussLegendre/Triangle 0.718 ± 0.021 ms 0.602 ± 0.0072 ms 1.19
time_to_load 1.48 ± 0.0049 s 1.47 ± 0.041 s 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f757e63) to head (c21b941).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #168   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          181       181           
=========================================
  Hits           181       181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeingold mikeingold changed the title WIP: Add official support for Frustum, Pyramid, and Wedge geometries Add official support for Frustum, Pyramid, and Wedge geometries Feb 19, 2025
JoshuaLampert and others added 2 commits February 19, 2025 13:58
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This looks good to me.

@JoshuaLampert
Copy link
Member

We should remember updating #28 and #67 once this is merged.

@mikeingold
Copy link
Collaborator Author

Thanks!

@mikeingold mikeingold merged commit d9b6fa1 into main Feb 19, 2025
12 checks passed
@mikeingold mikeingold deleted the newparams branch February 19, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants