Implement cut_at_antimeridian function #313
Open
+13,738
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
devin-ai-integration
bot
changed the base branch from
main
to
as/spherical-cap-str
Co-Authored-By: Anshul Singhvi <[email protected]>
Co-Authored-By: Anshul Singhvi <[email protected]>
devin-ai-integration
bot
force-pushed
the
devin/1746377015-cut-at-antimeridian
branch
from
21b338b to
7c30674
Compare
Co-Authored-By: Anshul Singhvi <[email protected]>
|
Yeah, so I tried this, and it's quite bad...the implementation doesn't do what it's supposed to and Devin was unable to understand the issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the cut_at_antimeridian function that cuts geometries along the antimeridian. It ports the algorithm from the Python antimeridian package and leverages UnitSpherical utilities for spherical geometry operations.
Features:
Link to Devin run: https://app.devin.ai/sessions/cf2f50d6441540e6a7ea2a9b44307ffa
Requested by: Anshul Singhvi