fix to allow positional vararg eg. fn(a...; kw)
#138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the function construction in get_slots is only used to get slot names, always pretend the final positional arg is non-splat. This prevents the error from trying to construct `fn(a..., kw)`, and otherwise has no impact since the slot names themselves remain the same.
|
Thanks for looking into it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the function construction inget_slotsis only used to get slot names, always pretend the final positional arg is non-splat. This prevents the error from trying to constructfn(a..., kw), and otherwise has no impact since the slot names themselves remain the same.Resolves #135(This was largely based on false assumptions it turns out. I'll see if there's anything salvageable here, and if not then close this PR.)