Add compat for Aqua and stdlibs #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Sbozzolo, thanks a lot for opening this PR and for the contribution, and sorry for the time to respond to it. Your PR is very very timely. In relation to #339 I've been checking Aqua, so I will leave a few suggestions to add which simply exploit further Aqua. I hope this afternoon I'll send you these suggestions. |
lbenet
reviewed
Nov 27, 2023
TaylorSeries.jl did not specify a compat for Aqua. Aqua 0.8 introduces some breaking changes, such as renaming test_piracy to test_piracies, leading to broken test if one has a recent version of Aqua in their environment. I added a compat for Aqua. New versions of Aqua also check for compats for standard libraries (which will be a requirement to publish the package), so I added those as well.
lbenet
approved these changes
Nov 27, 2023
|
Tests pass, so I'm merging. Thanks a lot @Sbozzolo !! |
I'd be personally in favor of bumping the patch version 😄 |
|
Me too... hold me on just a couple of days; I'm addressing #339, and noticed that some ambiguities may occur. (If this takes too long, I'll simply tag the new patch version.) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaylorSeries.jl did not specify a compat for Aqua. Aqua 0.8 introduces some breaking changes, such as renaming
test_piracytotest_piracies, leading to broken test if one has a recent version of Aqua in their environment.I added a compat for Aqua. New versions of Aqua also check for compats for standard libraries (which will be a requirement to publish the package), so I added those as well.