Skip to content

Do not require that function arguments are ::Function.#228

Merged
oxinabox merged 3 commits intoJuliaDiff:mainfrom
tpapp:tp/do-not-require-Function
Oct 30, 2023
Merged

Do not require that function arguments are ::Function.#228
oxinabox merged 3 commits intoJuliaDiff:mainfrom
tpapp:tp/do-not-require-Function

Conversation

@tpapp
Copy link
Copy Markdown
Contributor

@tpapp tpapp commented Oct 27, 2023

Fixes #224.

@tpapp
Copy link
Copy Markdown
Contributor Author

tpapp commented Oct 27, 2023

Style note: tell me if the struct I added for testing should be somewhere else, happy to move it. It was moved up front to make tests work on 1.0.

@wesselb
Copy link
Copy Markdown
Member

wesselb commented Oct 29, 2023

Hmmmm, @oxinabox or @willtebbutt, could either of you confirm whether this change could have any unintended consequences? I can't really recall if letting f be a function Function had a particular reason or not.

@willtebbutt
Copy link
Copy Markdown
Member

I can't see it being a problem.

@oxinabox
Copy link
Copy Markdown
Member

If tests pass then all is well

@oxinabox oxinabox merged commit fa05ca6 into JuliaDiff:main Oct 30, 2023
@oxinabox
Copy link
Copy Markdown
Member

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Argument limited to Functions

4 participants