-
Notifications
You must be signed in to change notification settings - Fork 22
feat: use JVPCache
for FiniteDiff pushforwards
#705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is this sufficient for sparse finitediff jacobians to be supported? |
Yes, but we'll have to benchmark performance to make sure that they are non-allocating |
The in place is fully non-allocating.
|
Nice! I'll add a non-allocation test to this PR to prevent regressions |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
==========================================
+ Coverage 97.96% 98.00% +0.03%
==========================================
Files 119 121 +2
Lines 6297 6353 +56
==========================================
+ Hits 6169 6226 +57
+ Misses 128 127 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JVPCache
Related:
finite_difference_jvp
FiniteDiff.jl#191