Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect array type in wrong-mode pushforward/pullback #620

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
+12 −4
Draft

fix: respect array type in wrong-mode pushforward/pullback #620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7c97dd8
fix: respect array type in wrong-mode pushforward/pullback
gdalle Nov 10, 2024
a6f4cbd
Merge branch 'main' into gd/coherent_map
gdalle Jan 29, 2025
dde3d4a
Correct map
gdalle Jan 30, 2025
8ac3c79
fix
gdalle Feb 9, 2025
0955815
Additional allocation to convert index array to same type as x/y
gdalle Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions DifferentiationInterface/src/first_order/pullback.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,9 @@ function _pullback_via_pushforward(
dy,
contexts::Vararg{Context,C},
) where {F,C}
dx = map(CartesianIndices(x)) do j
ind = CartesianIndices(x)
T = typeof(similar(x, eltype(ind)))
dx = map(x, T(ind)) do xj, j
t1 = pushforward(f, pushforward_prep, backend, x, (basis(x, j),), contexts...)
dot(only(t1), dy)
end
Expand Down Expand Up @@ -254,7 +256,9 @@ function _pullback_via_pushforward(
dy,
contexts::Vararg{Context,C},
) where {F,C}
dx = map(CartesianIndices(x)) do j # preserve shape
ind = CartesianIndices(x)
T = typeof(similar(x, eltype(ind)))
dx = map(x, T(ind)) do xj, j # preserve shape
t1 = pushforward(f!, y, pushforward_prep, backend, x, (basis(x, j),), contexts...)
dot(only(t1), dy)
end
Expand Down
8 changes: 6 additions & 2 deletions DifferentiationInterface/src/first_order/pushforward.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,9 @@
dx,
contexts::Vararg{Context,C},
) where {F,C}
dy = map(CartesianIndices(y)) do i
ind = CartesianIndices(y)
T = typeof(similar(y, eltype(ind)))
dy = map(y, T(ind)) do yi, i
t1 = pullback(f, pullback_prep, backend, x, (basis(y, i),), contexts...)
dot(only(t1), dx)
end
Expand Down Expand Up @@ -243,7 +245,9 @@
dx,
contexts::Vararg{Context,C},
) where {F,C}
dy = map(CartesianIndices(y)) do i # preserve shape
ind = CartesianIndices(y)
T = typeof(similar(y, eltype(ind)))
dy = map(y, T(ind)) do yi, i # preserve shape

Check warning on line 250 in DifferentiationInterface/src/first_order/pushforward.jl

View check run for this annotation

Codecov / codecov/patch

DifferentiationInterface/src/first_order/pushforward.jl#L248-L250 

Added lines #L248 - L250 were not covered by tests
t1 = pullback(f!, y, pullback_prep, backend, x, (basis(y, i),), contexts...)
dot(only(t1), dx)
end
Expand Down
Loading