-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some missing primal_value methods #47
Conversation
Thanks! Can you add tests for these? |
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=======================================
Coverage 83.00% 83.01%
=======================================
Files 5 5
Lines 459 465 +6
=======================================
+ Hits 381 386 +5
- Misses 78 79 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last suggestion. Afterward, if all tests pass, I think it's ready to merge.
Co-authored-by: Seth Axen <[email protected]>
This fixes #46 and defines missing primal_value methods for other backends too.