Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing primal_value methods #47

Merged
merged 7 commits into from
Feb 3, 2022

Conversation

mohamed82008
Copy link
Member

This fixes #46 and defines missing primal_value methods for other backends too.

@sethaxen
Copy link
Member

sethaxen commented Feb 3, 2022

Thanks! Can you add tests for these?

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #47 (28b9bb5) into master (be3de03) will increase coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   83.00%   83.01%           
=======================================
  Files           5        5           
  Lines         459      465    +6     
=======================================
+ Hits          381      386    +5     
- Misses         78       79    +1     
Impacted Files Coverage Δ
src/tracker.jl 94.44% <66.66%> (-5.56%) ⬇️
src/forwarddiff.jl 100.00% <100.00%> (ø)
src/reversediff.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be3de03...28b9bb5. Read the comment docs.

src/tracker.jl Show resolved Hide resolved
test/defaults.jl Outdated Show resolved Hide resolved
test/finitedifferences.jl Outdated Show resolved Hide resolved
Copy link
Member

@sethaxen sethaxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last suggestion. Afterward, if all tests pass, I think it's ready to merge.

test/tracker.jl Outdated Show resolved Hide resolved
Co-authored-by: Seth Axen <[email protected]>
@mohamed82008 mohamed82008 merged commit c04c033 into master Feb 3, 2022
@gdalle gdalle deleted the mt/primal_value_methods branch December 21, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

value_gradient_and_hessian for ForwardDiff returns gradient of type Dual
3 participants