-
Notifications
You must be signed in to change notification settings - Fork 18
Move README content to docstrings & update docs website #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
I think usually it's easier to not commit the Manifest file.
write implementer guide
I think this might require more discussion and changes in the code, so I'd suggest leaving it for a separate PR.
I agree, but still I think leaving the page in the docs makes sense, if only to show readers that there are two aspects to the package and only one is documented yet. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #106 +/- ##
=======================================
Coverage 82.94% 82.94%
=======================================
Files 8 8
Lines 428 428
=======================================
Hits 355 355
Misses 73 73
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to turn to something else for a while but I had a look at large parts of the PR. Here are some initial comments (that can probably be extrapolated).
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
thanks for the huge merge conflict from JuliaFormatter 🤣 |
Ooops, sorry 😬 |
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
I encountered a weird behavior where the cross-references in the docs wouldn't work with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I encountered a weird behavior where the cross-references in the docs wouldn't work with the AD shortcut for AbstractDifferentiation, even though I imported it as such in docs/make.jl. This explains the workflow failure on the penultimate commit. Do you think it's a Documenter bug or just me asking too much?
Based on the CI log, Documenter tries to resolve the references within the AbstractDifferentiation
/AD
module - but of course AD
does not exist there, only AbstractDifferentiation
. So maybe one option would be to set the current module to Main
.
Generally, I think it's not too bad (maybe even clearer?) if the docs do only use the user-defined convenience alias in the examples. On the other hand, it creates a slight inconsistency...
/docs/src/index.md | ||
/docs/Manifest.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe instead just change /Manifest.toml
to Manifest.toml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might need other manifests later on, e.g. for fully reproducible benchmarks
I do agree, but I don't think it should block this PR.
I looked around and I didn't find a way to do that in the kwargs of |
This was done initially but caused some problems (would have to look it up though). Generally, my gut feeling is that it is cleaner and easier to let users decide whether and what abbreviation they want to use. |
Thanks for the thorough review! |
README content is not discoverable by users in the REPL.
This PR fixes that by moving the function descriptions to docstrings, and updating the documentation website to reflect that.
docs/Manifest.toml
and activate CompatHelper ondocs/Project.toml
@primitive
does and how to use itNo actual Julia code has been changed except in
docs/make.jl