handle new declare_global intrinsic #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures all tests pass before and after JuliaLang/julia#58279 based on change from `Expr(:globaldecl, GlobalRef(M, S))` to `Core.declare_global(M, S, true)`, while still ignoring `Expr(:global, S)` from `struct` expanding to `strong=false`.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #138 +/- ##
===========================================
- Coverage 88.69% 76.46% -12.23%
===========================================
Files 6 6
Lines 1442 1534 +92
===========================================
- Hits 1279 1173 -106
- Misses 163 361 +198 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for approving running this one, but you need to approve and merge #136 first |
|
good to go? |
aviatesk
reviewed
Sep 29, 2025
aviatesk
approved these changes
Sep 29, 2025
|
thanks. merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures all tests pass before and after JuliaLang/julia#58279 (in conjunction with #137) based on change from
Expr(:globaldecl, GlobalRef(M, S))toCore.declare_global(M, S, true), while still ignoringExpr(:global, S)fromstructexpanding tostrong=false.