Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug x_noise argument in sim! and deprecate preparestate!(::SimModel, _ , _ ) #173

Merged
merged 3 commits into from
Mar 11, 2025

Conversation

franckgaga
Copy link
Member

@franckgaga franckgaga commented Mar 10, 2025

The x_noise keyword argument of sim! now works. It also deprecates:

preparestate!(model::SimModel, ym, d=[])

and replace it with:

preparestate!(model::SimModel)

The old method with ym and d arguments still works but it's now deprecated with Base.depwarn. The old method was not making sense since the two arguments were ignored. Moreover, it's now consistent with the updatestate! generic function, that is, it receives no measurement as argument for SimModel.

The old method with `ym` and `d` arguments still works but it's now deprecated.

The old method was not making sense since the two arguments were simply ignored. Moreover, it's now consistent with the `updatestate!` function, that is, it receive no measurement arguments for `SimModel`.
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.85%. Comparing base (ea1044b) to head (cf6096c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files          25       25           
  Lines        4118     4122    +4     
=======================================
+ Hits         4071     4075    +4     
  Misses         47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@franckgaga franckgaga merged commit 31cac69 into main Mar 11, 2025
4 checks passed
@franckgaga franckgaga deleted the doc_correction branch March 11, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants