debug: revert allocation-free linearize! to avoid NonLinModel type-instability
#160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 25865ea. (so `linearize!` is no longer allocation-free) *MOTIVE* The intricate solution with a `struct` and 5 separate closures creates a weird type-instability on `NonLinModel` when its `f` and `h` functions are not in the global scope. I'm not sure I fully understand why. In the end I prefer some small but deterministic allocations in `ForwardDiff.jacobian!` than a type-instability. I also benchmarked the two implementations, and the small allocations are way more performant than the type-instable version.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
==========================================
- Coverage 98.89% 98.57% -0.33%
==========================================
Files 24 24
Lines 3802 3787 -15
==========================================
- Hits 3760 3733 -27
- Misses 42 54 +12 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 25865ea. (so
linearize!is no longer allocation-free)MOTIVE
The intricate solution with a
structand 5 separate closures creates a weird type-instability onNonLinModelwhen itsfandhfunctions are not in the global scope. I'm not sure I fully understand why.In the end I prefer some small but deterministic allocations in
ForwardDiff.jacobian!than a type-instability. I also benchmarked the two implementations, and the small allocations are way more performant than the type-instable version.