Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: fallback if nonfinite arr. cov. after correction/update #156

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

franckgaga
Copy link
Member

@franckgaga franckgaga commented Feb 6, 2025

The fallback is still relevant if new NaN or Inf values appear in the covariance arrival. It just happened in CI (a NaN value was produced by the cholesky calls)

A different message is print tho to help troubleshooting. Since as mentioned by @baggepinnen, it may be caused by a different issue, like a sudden NaN values in the measurements ym.

The fallback is still relevant if new `NaN` or `Inf` values appear in the covariance arrival.

A different message is print tho to help troubleshooting.

As mentioned by @baggepinnen, it may be caused by a different issue, like a sudden NaN values in the measurements `ym`.
@franckgaga franckgaga merged commit d57c13e into main Feb 6, 2025
4 checks passed
@franckgaga franckgaga deleted the debug_mhe_fallback branch February 6, 2025 20:54
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.89%. Comparing base (e83ee42) to head (c693b0f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   98.89%   98.89%           
=======================================
  Files          24       24           
  Lines        3800     3806    +6     
=======================================
+ Hits         3758     3764    +6     
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants