Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed: @error instead of @warn in MHE arrival covariance fallback + update CI #154

Merged
merged 6 commits into from
Feb 6, 2025

Conversation

franckgaga
Copy link
Member

@franckgaga franckgaga commented Feb 6, 2025

Following the "convention" throughout the package, a non fatal @error log make more sense than @warn.
It's similar to @error emitted by an unfeasible MPC problem: something is wrong but there is a fallback. That is, take the solution from the last time step.

Also updated the CI.yml with new feature like improved speed with cache v2 and replacing Julia nightly by pre testing.

…riance

following the "convention" throughout the package, a non fatal `@error` make more sense. It's similar to unfeasible MPC problem : something is wrong but there is a fallback: take the solution from the last time step
@franckgaga franckgaga changed the title changed: @error instead of @warn in MHE fallback for arrival covariance changed: @error instead of @warn in MHE fallback for arrival covariance and update CI Feb 6, 2025
@franckgaga franckgaga changed the title changed: @error instead of @warn in MHE fallback for arrival covariance and update CI changed: @error instead of @warn in MHE arrival covariance fallback + update CI Feb 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.89%. Comparing base (cc2a92f) to head (701c5cc).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   98.89%   98.89%           
=======================================
  Files          24       24           
  Lines        3800     3800           
=======================================
  Hits         3758     3758           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franckgaga franckgaga merged commit e83ee42 into main Feb 6, 2025
3 of 4 checks passed
@franckgaga
Copy link
Member Author

FYI @baggepinnen

Might be worth it to update the test.yml file in ControlSystem.jl. See https://discourse.julialang.org/t/with-julia-actions-setup-julia-you-can-now-specify-lts-and-pre-named-versions/

The interesting parts would be to update to julia-actions/setup-julia@v2, actions/checkout@v4 and julia-actions/cache@v2. The v2 of cache speeds up the testing but requires this addition in the yml file:

    runs-on: ${{ matrix.os }} # new part just after this line:
    permissions: # needed for julia-actions/cache delete old caches that it has created
      actions: write
      contents: read

With v2 of setup-julia you can execute the tests on:

      matrix:
        version:
          - 'lts' # long-term support release
          - '1'   # latest stable 1.x release
          - 'pre' # latest stable prerelease
          # - 'nightly' # commented since noisy + 'pre' allows testing upcoming versions

IMO it covers large enough to see major issues for Julia version incompatibilities.

@franckgaga franckgaga deleted the error_log_mhe_arrival branch February 6, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants