added: call getinfo when debug logging is activated and not solved
#152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `Union` type was overly complex and `getinfo` should not be used in "normal" operation, only for troubleshoothing. The computational performance are not that important (there is already many allocations in this function)
The full output without ellipsis can still be shown in the REPL with the following logger: `debuglogger = ConsoleLogger(stderr, Logging.Debug, show_limited=false)`
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
==========================================
- Coverage 98.88% 98.88% -0.01%
==========================================
Files 24 24
Lines 3766 3765 -1
==========================================
- Hits 3724 3723 -1
Misses 42 42 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to
LinearMPC,NonLinMPCandMovingHorizonEstimatorgetinfois an expensive function but as mentioned in the doc, the function is not called at all when debug logging is disabled.It can be useful to get additionnal context in github CI. It theoretically allows the user to save the debug logging with full context in a separate file.
Before this change, I was only showing
JuMP.solution_summaryin the debug log.