Skip to content

Improve error message for missing paths in mount operations #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Keno wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve error message for missing paths in mount operations #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion deps/userns_common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,15 @@ void bind_mount(const char *src, const char *dest, char read_only) {
// We don't expect workspaces to have any submounts in normal operation.
// However, for runshell(), workspace could be an arbitrary directory,
// including one with sub-mounts, so allow that situation with MS_REC.
check(0 == mount(resolved_src, dest, "", MS_BIND|MS_REC, NULL));
int mount_result = mount(resolved_src, dest, "", MS_BIND|MS_REC, NULL);
if (mount_result != 0 && errno == ENOENT) {
// Provide a more descriptive error for missing paths
fprintf(stderr, "ERROR: Failed to mount '%s' to '%s': %s (errno %d)\n",
resolved_src, dest, strerror(errno), errno);
fprintf(stderr, " Please ensure that '%s' exists and is accessible.\n", resolved_src);
_exit(1);
}
check(mount_result == 0);

// remount to read-only. this requires a separate remount:
// https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/commit/?id=9ac77b8a78452eab0612523d27fee52159f5016a
Expand Down
Loading