Skip to content

Conversation

blegat
Copy link
Collaborator

@blegat blegat commented Oct 9, 2024

The code was written before MOI had its version of AllDifferent. It should now use MOI.AllDifferent so that the same model that can be solved by MiniZinc.jl etc... can also be solved by this package

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11256032217

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 95.383%

Totals Coverage Status
Change from base Build 10449145917: -0.1%
Covered Lines: 5020
Relevant Lines: 5263

💛 - Coveralls

@dourouc05
Copy link
Member

dourouc05 commented Oct 9, 2024

The PR looks good!

@blegat blegat merged commit 71ca3c7 into master Oct 9, 2024
8 checks passed
@blegat blegat mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants