Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using EltypeExtensions: elconvert #352

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

putianyi889
Copy link
Contributor

@putianyi889 putianyi889 commented Mar 14, 2024

The goal is to let multiple packages (FillArrays, QuasiArrays, LazyArrays, etc.) use the same elconvert while not having to depend on each other.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.48%. Comparing base (6f61dc3) to head (73373a0).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
- Coverage   99.91%   99.48%   -0.44%     
==========================================
  Files           8        8              
  Lines        1147     1154       +7     
==========================================
+ Hits         1146     1148       +2     
- Misses          1        6       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlfivefifty
Copy link
Member

Can you add a description to ElTypeExtensions.jl README?

@putianyi889
Copy link
Contributor Author

Can you add a description to ElTypeExtensions.jl README?

done.

@putianyi889
Copy link
Contributor Author

@dlfivefifty can you merge this?

@dlfivefifty dlfivefifty self-requested a review December 20, 2024 09:50
@dlfivefifty
Copy link
Member

I think this is fine but perhaps we should move EltypeExtensions.jl to JuliaArrays first?

It's better for it to be a community developed pacakge.

@dlfivefifty
Copy link
Member

I think elconvert is not a great name. convert_eltype would be preferable.

@putianyi889
Copy link
Contributor Author

It's better for it to be a community developed pacakge.

This is true.

move EltypeExtensions.jl to JuliaArrays

but this solution doesn't seem great. EltypeExtensions supports all kinds of collections, for example, it could be used for DomainSets.

@putianyi889 putianyi889 marked this pull request as ready for review December 24, 2024 19:30
@putianyi889
Copy link
Contributor Author

I think elconvert is not a great name. convert_eltype would be preferable.

Updated to [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants