Fix/release 3.9.1 by vrrayz · Pull Request #4932 · Joystream/pioneer

vrrayz · 2025-12-03T10:45:03Z

No description provided.

* Replace Subscan with Statescan * Fix formatting * Fix failing playwright install in CI checks

…m#4869) * react snap setup * react snap setup * react snap setup * seo * council and past council page * Add term start and end (estimated) dates for current term * total number of votes & total voting stake during Voting and Revealing period * Add Election Result and Revealed votes statistics * added past councils route and candidate vote highlight * latest election fields update * undo react-snap * removed uneccesary package update * removed uneccesary package update * chore: remove yarn.lock from tracked files * git error fix * chore: revert yarn.lock to match main * removed eslint comment Co-authored-by: Leszek Wiesner <[email protected]> * Apply suggestions from code review Co-authored-by: Leszek Wiesner <[email protected]> * Update packages/ui/src/index.html Co-authored-by: Leszek Wiesner <[email protected]> * Update packages/ui/src/council/components/pastCouncil/PastCouncilsList/PastCouncilListItem.tsx Co-authored-by: Leszek Wiesner <[email protected]> * Update packages/ui/src/council/components/election/pastElection/PastElectionStats.tsx Co-authored-by: Leszek Wiesner <[email protected]> * estimated ends at * council id * rearranged mock * review changes * review changes * test error fix --------- Co-authored-by: Leszek Wiesner <[email protected]>

* Replace Subscan with Statescan (Joystream#4867) * Replace Subscan with Statescan * Fix formatting * Fix failing playwright install in CI checks * Bump version to 3.7.3 --------- Co-authored-by: Theophile Sandoz <[email protected]>

* Replace Subscan with Statescan (Joystream#4867) * Replace Subscan with Statescan * Fix formatting * Fix failing playwright install in CI checks * Council and election pages: Small enhancements - Issue 4866 (Joystream#4869) * react snap setup * react snap setup * react snap setup * seo * council and past council page * Add term start and end (estimated) dates for current term * total number of votes & total voting stake during Voting and Revealing period * Add Election Result and Revealed votes statistics * added past councils route and candidate vote highlight * latest election fields update * undo react-snap * removed uneccesary package update * removed uneccesary package update * chore: remove yarn.lock from tracked files * git error fix * chore: revert yarn.lock to match main * removed eslint comment Co-authored-by: Leszek Wiesner <[email protected]> * Apply suggestions from code review Co-authored-by: Leszek Wiesner <[email protected]> * Update packages/ui/src/index.html Co-authored-by: Leszek Wiesner <[email protected]> * Update packages/ui/src/council/components/pastCouncil/PastCouncilsList/PastCouncilListItem.tsx Co-authored-by: Leszek Wiesner <[email protected]> * Update packages/ui/src/council/components/election/pastElection/PastElectionStats.tsx Co-authored-by: Leszek Wiesner <[email protected]> * estimated ends at * council id * rearranged mock * review changes * review changes * test error fix --------- Co-authored-by: Leszek Wiesner <[email protected]> * Bump version, update CHANGELOG --------- Co-authored-by: Theophile Sandoz <[email protected]> Co-authored-by: Victor Emmanuel <[email protected]>

)

Co-authored-by: Theophile Sandoz <[email protected]>

Co-authored-by: Oleksandr Korniienko <[email protected]> Co-authored-by: Theophile Sandoz <[email protected]>

…into fix/release-3.9.1

traumschule · 2025-12-03T14:25:59Z

Thanks! Merged, two are still flaky

FAIL test/proposals/hooks/useProposals.test.tsx (933 MB heap size)
  ● useProposals › Status: active | past › Status: active

    expect(received).toBeTruthy()

    Received: false

      33 |       expect(result.proposals.length).toBeGreaterThan(0)
      34 |       result.proposals.forEach((proposal) => {
    > 35 |         expect(proposalActiveStatuses.includes(proposal.status)).toBeTruthy()
         |                                                                  ^
      36 |       })
      37 |     })
      38 |

      at forEach (test/proposals/hooks/useProposals.test.tsx:35:66)
          at Array.forEach (<anonymous>)
      at Object.<anonymous> (test/proposals/hooks/useProposals.test.tsx:34:24)

FAIL test/forum/modals/CreatePostModal.test.tsx (6.892 s, 895 MB heap size)
  ● UI: CreatePostModal › Transaction success

    Unable to find an element with the text: Your post has been submitted.. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

    Ignored nodes: comments, <script />, <style />
    <body>
      <div />
    </body>

      117 |     })
      118 |
    > 119 |     expect(await screen.findByText('Your post has been submitted.')).toBeDefined()
          |                         ^
      120 |   })
      121 |
      122 |   it('Displays post deposit', () => {

      at waitForWrapper (../../node_modules/@testing-library/react/node_modules/@testing-library/dom/dist/wait-for.js:187:27)
      at findByText (../../node_modules/@testing-library/react/node_modules/@testing-library/dom/dist/query-helpers.js:101:32)
      at Object.<anonymous> (test/forum/modals/CreatePostModal.test.tsx:119:25)


Test Suites: 2 failed, 1 skipped, 111 passed, 113 of 114 total
Tests:       2 failed, 4 skipped, 701 passed, 707 total

vrrayz · 2025-12-03T15:03:35Z

Thanks! Merged, two are still flaky

FAIL test/proposals/hooks/useProposals.test.tsx (933 MB heap size)
  ● useProposals › Status: active | past › Status: active

    expect(received).toBeTruthy()

    Received: false

      33 |       expect(result.proposals.length).toBeGreaterThan(0)
      34 |       result.proposals.forEach((proposal) => {
    > 35 |         expect(proposalActiveStatuses.includes(proposal.status)).toBeTruthy()
         |                                                                  ^
      36 |       })
      37 |     })
      38 |

      at forEach (test/proposals/hooks/useProposals.test.tsx:35:66)
          at Array.forEach (<anonymous>)
      at Object.<anonymous> (test/proposals/hooks/useProposals.test.tsx:34:24)

FAIL test/forum/modals/CreatePostModal.test.tsx (6.892 s, 895 MB heap size)
  ● UI: CreatePostModal › Transaction success

    Unable to find an element with the text: Your post has been submitted.. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

    Ignored nodes: comments, <script />, <style />
    <body>
      <div />
    </body>

      117 |     })
      118 |
    > 119 |     expect(await screen.findByText('Your post has been submitted.')).toBeDefined()
          |                         ^
      120 |   })
      121 |
      122 |   it('Displays post deposit', () => {

      at waitForWrapper (../../node_modules/@testing-library/react/node_modules/@testing-library/dom/dist/wait-for.js:187:27)
      at findByText (../../node_modules/@testing-library/react/node_modules/@testing-library/dom/dist/query-helpers.js:101:32)
      at Object.<anonymous> (test/forum/modals/CreatePostModal.test.tsx:119:25)


Test Suites: 2 failed, 1 skipped, 111 passed, 113 of 114 total
Tests:       2 failed, 4 skipped, 701 passed, 707 total

Its been a while so i can't remember if active and past are part of the values for the status key and from the issue i checked the mock data testProposals and noticed it doesn't have proposals with status:active hence why it would always return false.

in packages\ui\src\proposals\hooks\useProposals.ts there's this type UseProposalsStatus = 'active' | 'past'
but in the mock data for testProposals there are different statuses and none of them make use of UseProposalsStatus type

The second case happens because src\forum\modals\PostActionModal\CreatePostModal didn't have the success message set here const [state, send] = useMachine( defaultTransactionModalMachine('There was a problem posting your message.', undefined), { context: { validateBeforeTransaction: true } } )

traumschule · 2025-12-03T17:42:04Z

Thanks again. Since the test started failing since #4887 I assume we should remove vetoed proposals from the mock data in test/_mocks/proposals/index.ts.. Closing this and will apply fix in #4927.

thesan and others added 30 commits August 10, 2024 21:43

🪢 Merge 3.7.2 into dev (Joystream#4864)

90a20ce

Replace Subscan with Statescan (Joystream#4867)

cbf1083

* Replace Subscan with Statescan * Fix formatting * Fix failing playwright install in CI checks

🚀 Release 3.7.3 (Joystream#4868)

7b4ffd1

* Replace Subscan with Statescan (Joystream#4867) * Replace Subscan with Statescan * Fix formatting * Fix failing playwright install in CI checks * Bump version to 3.7.3 --------- Co-authored-by: Theophile Sandoz <[email protected]>

Update mainnet RPC endpoint (Joystream#4871)

53bc361

Show 50 validators per page (Joystream#4877)

4883e2d

Update balance tooltip position (Joystream#4884)

2ab7ca9

Refresh the Election page after Restore Votes is clicked (Joystream#4885

63d198a

)

Update MyRole tooltip (Joystream#4883)

135f14f

Move action buttons to the left (Joystream#4886)

f068abd

Add Latest posts to the forum (Joystream#4881)

85d019a

Add MyThreads counter (Joystream#3929)

8622024

Co-authored-by: Theophile Sandoz <[email protected]>

Tooltip for deactivated AddProposalButton (Joystream#3909)

20ed7ce

Co-authored-by: Oleksandr Korniienko <[email protected]> Co-authored-by: Theophile Sandoz <[email protected]>

Fixed icons (Joystream#4890)

ba4349c

Temp. fix ExternalResourceLink (Joystream#4875)

b6bf337

🚀 Release 3.9.0

776bc24

Contributors

85178c1

CHANGELOG

2d21100

Limit Proposal whitelist to 20 members (Joystream#4684)

42fd225

Sort Openings (Joystream#4191)

5405c58

Fix OpeningFormPreview (Joystream#4902)

1e09b80

Hide Coming Soon (Joystream#4891)

1f9a4a6

Fix Tooltip: div -> span (Joystream#4900)

98bb600

Fix buttons on My Memberships (Joystream#4912)

b76f69d

Update rivalrous lock handbook link (Joystream#4896)

2cca1df

Forum: Don't Truncate Thread Title (Joystream#4913)

c1b1657

Forum: Group search results (Joystream#4922)

5caf472

Forum: Remove post confirmation modal (Joystream#4920)

c70c40c

Hide input field for archived threads (Joystream#4923)

bfd4953

vercel bot deployed to Preview – pioneer-2 December 3, 2025 11:50 View deployment

vercel bot deployed to Preview – dao December 3, 2025 11:55 View deployment

vercel bot deployed to Preview – pioneer-2-storybook December 3, 2025 11:57 View deployment

proposaldisccusion apollo provider wrapper

d78767e

vercel bot deployed to Preview – pioneer-2 December 3, 2025 12:17 View deployment

vercel bot deployed to Preview – dao December 3, 2025 12:24 View deployment

vercel bot deployed to Preview – pioneer-2-storybook December 3, 2025 12:26 View deployment

WGL: Vested / Discretionary spending (Joystream#4906)

b584e74

vrrayz closed this Dec 3, 2025

reactivate Validator tests

be59094

vrrayz reopened this Dec 3, 2025

vrrayz changed the base branch from dev to main December 3, 2025 14:09

traumschule and others added 2 commits December 3, 2025 15:17

lint

7562007

Merge branch 'release-3.9.1' of https://github.com/traumschule/pioneer …

464f3c5

…into fix/release-3.9.1

vercel bot deployed to Preview – pioneer-2 December 3, 2025 14:43 View deployment

vercel bot deployed to Preview – pioneer-2-storybook December 3, 2025 14:46 View deployment

vercel bot deployed to Preview – dao December 3, 2025 14:51 View deployment

added success message to create post modal

9b29251

vercel bot deployed to Preview – pioneer-2-storybook December 3, 2025 15:40 View deployment

vercel bot deployed to Preview – dao December 3, 2025 15:45 View deployment

vercel bot deployed to Preview – pioneer-2 December 3, 2025 15:51 View deployment

added logging

d267a96

vercel bot deployed to Preview – pioneer-2-storybook December 3, 2025 16:52 View deployment

vercel bot deployed to Preview – dao December 3, 2025 16:57 View deployment

vercel bot deployed to Preview – pioneer-2 December 3, 2025 17:02 View deployment

traumschule closed this Dec 3, 2025

traumschule added a commit to traumschule/pioneer that referenced this pull request Dec 3, 2025

turn vetoed mock proposal dormant (Joystream#4932)

cf8d40d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/release 3.9.1#4932

Fix/release 3.9.1#4932
vrrayz wants to merge 56 commits intoJoystream:mainfrom
vrrayz:fix/release-3.9.1

vrrayz commented Dec 3, 2025

Uh oh!

traumschule commented Dec 3, 2025

Uh oh!

vrrayz commented Dec 3, 2025 •

edited

Loading

Uh oh!

traumschule commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

vrrayz commented Dec 3, 2025

Uh oh!

traumschule commented Dec 3, 2025

Uh oh!

vrrayz commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

traumschule commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vrrayz commented Dec 3, 2025 •

edited

Loading