Skip to content

restore insert table button#4444

Closed
traumschule wants to merge 1 commit intoJoystream:devfrom
traumschule:patch-18
Closed

restore insert table button#4444
traumschule wants to merge 1 commit intoJoystream:devfrom
traumschule:patch-18

Conversation

@traumschule
Copy link
Collaborator

reviewing #4032 it looks like a mistake to remove the button

@vercel
Copy link

vercel bot commented Jun 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Jun 17, 2023 5:58pm
pioneer-2 ✅ Ready (Inspect) Visit Preview Jun 17, 2023 5:58pm
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Jun 17, 2023 5:58pm

Copy link
Collaborator Author

@traumschule traumschule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@traumschule traumschule added high-prio community-dev issue suitable for community-dev pipeline builders-wg-code-review labels Jun 17, 2023
@thesan
Copy link
Collaborator

thesan commented Jun 19, 2023

@traumschule I'm confused, is this problem not happening anymore: #4032 (comment) ?

@traumschule
Copy link
Collaborator Author

it's fine for me.

@chrlschwb
Copy link
Contributor

@traumschule is the above screenshot the "preview" modal?
Preview mode works well for me as well, but the actual post displays like this.
https://dao-git-fork-traumschule-patch-18-joystream.vercel.app/#/forum/thread/460?post=4051

There is some conflict between the ckeditor plugin and the ReactMarkdown component.
Ckeditor uses HTML markdown, while the current setting uses GFM.

Copy link
Collaborator

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR shouldn't get merged until this #4444 (comment) gets fixed.

@traumschule
Copy link
Collaborator Author

Closing in favor of #4935

@traumschule traumschule closed this Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-dev issue suitable for community-dev pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants