Conversation
Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JosunLP <[email protected]>
|
@codex[agent] update the version and the changelog |
There was a problem hiding this comment.
Pull request overview
Updates the project’s installation/uninstallation flow to support “single-line” streaming execution (curl/irm piped into shell/PowerShell) while keeping archive-bundle installs working.
Changes:
- README: replaces download-then-run examples with streamed one-liners and adds a note about manual review.
- Unix installer: makes script-directory detection safe for streamed execution and only attempts local-binary install when the script path is a real file.
- Windows installer: makes script/binary path detection safe for streamed execution and guards local-binary install accordingly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Switches install/uninstall examples to piped execution and documents review option. |
| scripts/install-unix.sh | Avoids assuming $BASH_SOURCE is a file; gates local-binary installation on valid script dir. |
| scripts/install-windows.ps1 | Avoids assuming $MyInvocation.MyCommand.Path exists; gates local-binary installation on valid paths. |
|
@copilot apply changes based on the comments in this thread |
Version bumped to 1.3.1 and changelog updated with the install/uninstall changes (0374ab9). |
|
@copilot apply changes based on the comments in this thread |
Applied in 7c1e262. The README now uses
Applied in 7c1e262. The README now uses |
|
@copilot apply changes based on the comments in this thread |
Agent-Logs-Url: https://github.com/JosunLP/sort-it-now/sessions/fc712359-8453-400e-8dd8-1bc9529374c4 Co-authored-by: JosunLP <[email protected]>
Applied in 4892975. The README now marks the default streamed Windows install command as an Administrator/elevated PowerShell flow and points to |
This pull request updates the installation and uninstallation instructions and scripts for both Unix and Windows. The main goal is to simplify the process by allowing users to stream the scripts directly into their shells, while still supporting manual review if desired. Additionally, the scripts have been improved to handle cases where they are executed directly from a stream and not from a file.
README and documentation improvements:
README.mdto use direct streaming of scripts viacurl(Unix) andirm(PowerShell), reducing the need for temporary file downloads. Added a note about how to manually review scripts if preferred.Unix install script (
install-unix.sh) improvements:$SCRIPT_SOURCEis not a file.Windows install script (
install-windows.ps1) improvements:$scriptPathexists and setting$binaryPathaccordingly.