Conversation
Housekeeping
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
…e für nicht unterstützte macOS-Architekturen hinzu
* ✨ Füge Unterstützung für die Rotation von Objekten hinzu: Ermöglicht alternative Ausrichtungen während des Verpackungsprozesses und aktualisiert die Benutzeroberfläche zur Konfiguration. * Optimize rotation deduplication and standardize epsilon handling (#14) * Initial plan * Address PR review comments: optimize orientation deduplication and standardize epsilon values Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Extract dimension hash scale factor to named constant and reduce overflow risk Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Fix misleading comment about dimension hash scale factor Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Remove unused dims_almost_equal function after optimization Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Remove unnecessary blank line for code consistency Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Add test coverage for orientation deduplication with equal dimensions Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Add clarifying comments for O(n²) uniqueness checks in tests Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Fix trailing whitespace and align frontend epsilon to backend precision Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Update src/optimizer.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jonas Pfalzgraf <jolun.swtor@gmail.com> --------- Signed-off-by: Jonas Pfalzgraf <jolun.swtor@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Co-authored-by: Jonas Pfalzgraf <info@josunlp.de> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jonas Pfalzgraf <jolun.swtor@gmail.com> * Move allow_rotations documentation to API endpoints section (#15) * Initial plan * Move allow_rotations documentation to API endpoints section Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Signed-off-by: Jonas Pfalzgraf <jolun.swtor@gmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Initial plan * Add Docker deployment support with GitHub Actions workflow Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Add Docker setup documentation and update Dockerfile to use latest Rust Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Address code review feedback: pin Rust version and improve placeholders Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Apply PR review feedback: security, caching, and documentation improvements Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Apply second round of PR review feedback Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Apply third round of PR review feedback Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Apply fourth round of PR review feedback Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
…n permissions (#16) Signed-off-by: Jonas Pfalzgraf <jolun.swtor@gmail.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jonas Pfalzgraf <jolun.swtor@gmail.com>
* Initial plan
* Add conditional checks to Docker workflow to skip when secrets are not configured
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
* Remove redundant ${{ }} wrappers from if conditionals in Docker workflow
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
* Initial plan * Revert invalid secret conditionals in Docker workflow Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
#20) * Initial plan * Add unit tests for parse_bool and clarify allow_rotations fallback behavior Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Remove trailing whitespace from blank comment lines in test code Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
- Updated dependencies in Cargo.toml for axum, tokio, tower-http, rust-embed, tempfile, flate2, and zip.
- Changed API route pattern from "/*path" to "{*path}" for better path matching.
- Added #[allow(dead_code)] annotations to several functions in model.rs, geometry.rs, optimizer.rs to suppress warnings for unused code.
* Initial plan * Address Docker review feedback - improve .dockerignore, add dev tag, clarify Dockerfile Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Update .dockerignore Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jonas Pfalzgraf <jolun.swtor@gmail.com> --------- Signed-off-by: Jonas Pfalzgraf <jolun.swtor@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Co-authored-by: Jonas Pfalzgraf <jolun.swtor@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…vior (#21) * Initial plan * Add comprehensive test coverage for allow_rotations field Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jonas Pfalzgraf <jolun.swtor@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jonas Pfalzgraf <jolun.swtor@gmail.com>
* Initial plan * Fix Docker CMD to ENTRYPOINT to prevent argument override Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> * Erweitere Docker-Workflow mit Geheimnisvalidierung, Trivy-Sicherheitsprüfung und verbesserten Dockerfile-Optimierungen. Füge Docker Compose-Datei hinzu. * Aktualisiere Trivy-Scanner-Konfiguration, um das erste Tag aus der Metadaten-Aktion zu verwenden --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
…ex.html, and script.js - Translated error messages, UI labels, and comments from German to English for better accessibility. - Ensured consistency in terminology across the application. - Improved user experience by providing English language support in the UI.
…in copilot-instructions.md
There was a problem hiding this comment.
Pull request overview
This pull request introduces version 1.2.0, a major modernization release that comprehensively translates the entire codebase from German to English and introduces significant architectural improvements through OOP and DRY principles. The changes include a new core types module with reusable geometric types and traits, enhanced Docker deployment workflows with security scanning, and updated documentation throughout the project.
Key changes:
- Complete translation from German to English across code, documentation, and frontend
- New
types.rsmodule withVec3,BoundingBox, and polymorphic traits (Dimensional,Positioned,Weighted) - Enhanced Docker workflow with multi-arch builds, SBOM/provenance generation, and Trivy vulnerability scanning
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| web/script.js | Translated all UI strings, comments, and error messages from German to English |
| web/index.html | Updated HTML lang attribute and all UI text to English |
| src/update.rs | Translated console output messages and comments to English |
| src/types.rs | New module with core 3D types, traits, validation functions, and comprehensive tests |
| src/optimizer.rs | Translated documentation and algorithm comments to English with enhanced docstrings |
| src/model.rs | Refactored to implement new traits with DRY validation helpers |
| src/main.rs | Added module documentation and translated console messages |
| src/geometry.rs | Enhanced with BoundingBox support and additional utility functions |
| src/config.rs | Translated configuration messages and error handling to English |
| src/api.rs | Translated API documentation and error messages to English |
| scripts/install-windows.ps1 | Translated PowerShell script messages to English |
| scripts/install-unix.sh | Translated shell script messages to English |
| package.json | Version bump to 1.2.0 |
| docker-compose.yml | New Docker Compose configuration with healthcheck and resource limits |
| README.md | Complete translation to English with updated examples and instructions |
| Dockerfile | Added web assets copy, healthcheck, ENTRYPOINT, and optimization flags |
| DOCKER_SETUP.md | Translated Docker deployment guide to English |
| Cargo.toml | Version bump to 1.2.0 and added release profile optimizations |
| CONCEPT.md | Translated concept documentation to English |
| CHANGELOG | Added detailed v1.2.0 changelog entry |
| .github/workflows/docker.yml | Added secret validation, QEMU setup, Trivy scanning, and SARIF upload |
| .github/copilot-instructions.md | New comprehensive developer documentation (741 lines) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…mpose.yml und types.rs
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request introduces a major release (v1.2.0) focused on codebase modernization, improved maintainability, and enhanced Docker deployment workflows. The changes include a comprehensive translation of the project from German to English (code, docs, and frontend), a new core types module with OOP and DRY principles, significant Dockerfile and CI workflow improvements for security and reliability, and updated documentation throughout the project.
Key changes:
Core Codebase Refactoring & Modernization
types.rsmodule with reusable types (Vec3,BoundingBox), polymorphic traits (Dimensional,Positioned,Weighted), and utility functions for validation and center of mass calculations. This refactoring enforces OOP and DRY principles and improves code organization.model.rsandgeometry.rsto leverage new traits and types, improving maintainability and testability.Docker & CI/CD Improvements
Documentation & Release Management
README.md,CONCEPT.md,DOCKER_SETUP.md) to English, reflecting new architecture and deployment instructions. [1] [2] [3] [4]Versioning & Build Optimization
1.2.0inCargo.tomland enabled release profile optimizations (LTO, strip, codegen-units=1). [1] [2]These changes collectively modernize the codebase, improve developer experience, and enhance deployment security and reliability.