Remove uses of System.ValueTuple #2324
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
System.ValueTuple is not included in net462. For reasons that I can't explain, I am seeing test errors on another branch in VS (but not on the command line) relating to missing System.Runtime.CompilerServices.Unsafe assembly. That assembly seems to be a runtime dependency (?) of System.Memory 4.5.0 which this library references. Bumping System.Memory to 4.5.5 appears to fix those issues, but the net462 build fails due to missing System.ValueTuple on net462. I guess System.Memory 4.5.0 brings that in implicitly (it is not listed as a dependency). Instead of adding an explicit reference to the System.ValueTuple package on net462, we can just remove the few internal uses. tl;dr this unblocks bumping the System.Memory version which fixes some local test issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.ValueTuple is not included in net462. For reasons that I can't explain, I am seeing local test errors in #2142 in VS (but not on the command line) relating to missing System.Runtime.CompilerServices.Unsafe assembly. That assembly seems to be a runtime dependency (?) of System.Memory 4.5.0 which this library references.
Bumping System.Memory to 4.5.5 appears to fix those issues, but the net462 build fails due to missing System.ValueTuple on net462. I guess System.Memory 4.5.0 brings that in implicitly (it is not listed as a dependency). Instead of adding an explicit reference to the System.ValueTuple package on net462, we can just remove the few internal uses.
tl;dr this unblocks bumping the System.Memory version which fixes some strange local test issues