:key="index" => :key="JSON.stringify(suggestion)"#476
Open
SaulIO wants to merge 1 commit intoJosephusPaye:masterfrom
Open
:key="index" => :key="JSON.stringify(suggestion)"#476SaulIO wants to merge 1 commit intoJosephusPaye:masterfrom
SaulIO wants to merge 1 commit intoJosephusPaye:masterfrom
Conversation
The framework needs the keys to be stable for performant rerender. Index is inherently unstable.
Owner
JosephusPaye
left a comment
JosephusPaye
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just one thing to consider.
|
|
||
| :highlighted="highlightedIndex === index" | ||
| :key="index" | ||
| :key="JSON.stringify(suggestion)" |
Owner
There was a problem hiding this comment.
This could potentially lead to an error if suggestion has a circular reference.
Probably not likely, but it's something to keep in mind.
Maybe we could just require a unique key property on the suggestion if it's an object?
Contributor
Author
There was a problem hiding this comment.
Not sure how likely there is a good use case for a circular reference within an autocomplete though?
At that level it seems more like a coding error.
Could require a key, but automating is nice. Tbf, I'd probably slice it too after stringify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The framework needs the keys to be stable for performant rerender. Index is inherently unstable.