-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added feature of changing the color temperature of the screen #296
Conversation
This pull request has been automatically marked as stale because it has not had |
@Andoramb Could you solve the merge conflicts? |
Sure, I'll have a look! |
Hey :)
I changed this locally to have
On my branch by default Let me know what do you think about the |
@Andoramb Sorry, I didn't close the PR on purpose! But I can't seem to reopen it.
It's already a percentage. 100% is the default, and anything above is brighter - some parts are dimmed (like the seconds on the clock module), so you will see a difference there if you choose 200. The brightness-related code could probably be refactored, I think I will do that after we get your "color temperature" into the project. Are you open to create a new PR? If I could find the time, I could try to cherry pick the commits from this PR and implement the function. What do you think? |
Okay, I cherry picked your changes and just released version 3.1.0 with it. There were some merge conflicts to solve. Would be nice if you check the functionality. For me it seems to work 🙂 Thanks for this improvement! 🚀 |
Oh that's great! |
One more thing here:
|
Oh, thanks! I just released a new version to fix that! 😃 |
Feature Addition
Description
Hi, I have added a slider for changing the color temperature of the display.
It acts the same way changing the brightness:
TEMP
notification can be called to change it from notificationChangelog
Couple files were modified when adding this, but essentially it's a copy from the brightness slider.
Additionally some css code was modified to fit the temp slider
Requirements
Try to test it, it works for me locally
Additional info
Let me know what do you think of it 🙂