Skip to content

Fix issues #1267 and #1290 #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KshitizGIT wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix issues #1267 and #1290 #1291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b143f32
fix #1267
KshitizGIT Jun 28, 2024
44eedb0
Fix #1290
KshitizGIT Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions johnsnowlabs/auto_install/databricks/install_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,9 +431,11 @@ def install_py_lib_via_pip(
:return:
"""
# By not defining repo, we will use default pip index
pypi = dict(package=pypi_lib)
package = pypi_lib
if version:
pypi["version"] = version
package = f"{package}=={version}"

pypi = dict(package=package)
payload = [dict(pypi=pypi)]
db.managed_library.install_libraries(cluster_id=cluster_id, libraries=payload)
if version:
Expand Down
1 change: 0 additions & 1 deletion johnsnowlabs/py_models/jsl_secrets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,6 @@ def build_or_try_find_secrets(
JSL_FINANCE_LICENSE=fin_license,
)
print('👌 License info detected in arguments')
return secrets
elif access_token:
secrets = JslSecrets.from_access_token(
access_token, remote_license_number
Expand Down