Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: top_result was not correctly fetched #232

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: top_result was not correctly fetched #232

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9bed61f
fix: top_result was not correctly fetched
dri-mobisec Nov 15, 2024
17be86a
Merge pull request #1 from mobisecitalia/task-fix-top-result
dri-mobisec Nov 15, 2024
f0aa638
fix: added TypeError catch to top_result in search
dri-mobisec Nov 19, 2024
ce11ed5
Merge pull request #2 from mobisecitalia/task-hotfix-typeerror
dri-mobisec Nov 19, 2024
ecac29e
fix: subsituted TypeError with generic Exception in search top_result
dri-mobisec Nov 19, 2024
c9ec966
Merge pull request #3 from mobisecitalia/task-hotfix-typeerror
dri-mobisec Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google_play_scraper/features/search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ def search(
dataset[key] = value

try:
top_result = dataset["ds:4"][0][1][0][23][16]
except IndexError:
top_result = dataset["ds:4"][0][1][1][23][16]
except Exception:
top_result = None

success = False
Expand Down