fix camera upload for mobile

[chiragchhatrala]

@JhumanJ please review this on your local

Summary by CodeRabbit

• New Features

  • Enhanced camera upload functionality with improved error handling
  • Added more robust webcam stream management

• Bug Fixes

  • Improved camera permission error detection and handling
  • Updated video element styling for better visual presentation

[coderabbitai]

Walkthrough

The pull request focuses on enhancing the CameraUpload.vue component's camera upload functionality. The primary modifications include updating the openCameraUpload method to be asynchronous, improving error handling for camera access, and refining the video element's template structure. The changes aim to make the camera upload process more robust by implementing better stream management and error detection when accessing the user's camera.

Changes

File	Change Summary
client/components/forms/components/CameraUpload.vue	- Updated openCameraUpload() method to be asynchronous - Enhanced error handling for camera access - Modified video element template with new attributes and classes - Restructured webcam stream initialization logic

Sequence Diagram

sequenceDiagram
    participant User
    participant Component as CameraUpload
    participant Browser as Browser APIs
    
    User->>Component: Trigger openCameraUpload()
    Component->>Browser: Request camera access
    alt Camera Access Successful
        Browser-->>Component: Return Media Stream
        Component->>Component: Attach Stream to Video
        Component->>User: Display Camera View
    else Camera Access Failed
        Browser-->>Component: Return Error
        Component->>Component: Update Permission Status
        Component->>User: Show Error Handling
    end

Loading

Possibly related PRs

• Camera Upload UI fixes #487: Changes to CameraUpload.vue component's UI elements related to camera actions

Suggested reviewers

• JhumanJ

Poem

🐰 A camera's dance, async and bright,
Streams flowing with technical might,
Permissions checked, errors in sight,
Vue component leaps with rabbit's delight,
Webcam's embrace, now smooth and tight! 📸✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

client/components/forms/components/CameraUpload.vue (2)

8-14: Enhance video element accessibility.

Including the muted attribute is good for auto-playing clips (especially on iOS). For accessibility, consider adding a descriptive label so screen-reader users know there is a camera feed present.

<video
  id="webcam"
  autoplay
  playsinline
  muted
  :class="[
    { hidden: !isCapturing }, 
    theme.fileInput.minHeight, 
    theme.fileInput.borderRadius,
    'w-full h-full object-cover'
  ]"
+ aria-label="Real-time camera feed for capturing images"
  webkit-playsinline
/>

---

155-206: Refine error handling and lifecycle by resetting capture state on failure.

When camera permissions are denied or an error occurs, isCapturing remains true, potentially confusing the UI. Consider resetting it to false and centralizing webcam stream startup/shutdown within the library's own start() and stop() for maintainability.

} catch (err) {
  console.error('Camera error:', err)
+ this.isCapturing = false
  if (err.name === 'NotAllowedError' ...

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 932585b and 46edec3.

📒 Files selected for processing (1)

• client/components/forms/components/CameraUpload.vue (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Build the Nuxt app