Refactor editor panels #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JhumanJ
requested changes
Nov 23, 2023
| <editor-options-panel name="About Submissions" v-model="isCollapseOpen"> | ||
| <template #icon> | ||
| <svg | ||
| class="h-5 w-5 inline mr-2 -mt-0.5 transition-colors" :class="{'text-blue-600':isCollapseOpen, 'text-gray-500':!isCollapseOpen}" |
There was a problem hiding this comment.
Here all classes excepct the width/height must be removed. You can put the rest if needed in EditorOptionsPanel, so that we won't have to do the same thing for the blue color in all components. you can also remove isCollapseOpen since we won't need it anymore in this component after this change
JhumanJ
approved these changes
Nov 28, 2023
JhumanJ
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.