Fix redirect URL mentions (#707)

JhumanJ · Feb 24, 2025 · 65eebb7 · 65eebb7
1 parent d190211
commit 65eebb7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/api/app/Service/Forms/FormSubmissionProcessor.php b/api/app/Service/Forms/FormSubmissionProcessor.php
@@ -57,8 +57,12 @@ private function isFieldUsedInRedirectUrl(Form $form, string $fieldId): bool
      */
     public function getRedirectData(Form $form, array $submissionData): array
     {
+        $formattedData = collect($submissionData)->map(function ($value, $key) {
+            return ['id' => $key, 'value' => $value];
+        })->values()->all();
+
         $redirectUrl = ($form->redirect_url)
-            ? (new MentionParser($form->redirect_url, array_values($submissionData)))->urlFriendlyOutput()->parseAsText()
+            ? (new MentionParser($form->redirect_url, $formattedData))->urlFriendlyOutput()->parseAsText()
             : null;
 
         if ($redirectUrl && !filter_var($redirectUrl, FILTER_VALIDATE_URL)) {

diff --git a/api/tests/Feature/Forms/FormSubmissionProcessorTest.php b/api/tests/Feature/Forms/FormSubmissionProcessorTest.php
@@ -121,10 +121,7 @@
 
     $processor = new FormSubmissionProcessor();
     $redirectData = $processor->getRedirectData($form, [
-        'field_1' => [
-            'id' => 'field_1',
-            'value' => 'test-value'
-        ]
+        'field_1' => 'test-value'
     ]);
 
     expect($redirectData)->toBe([
@@ -142,10 +139,7 @@
 
     $processor = new FormSubmissionProcessor();
     $redirectData = $processor->getRedirectData($form, [
-        'field_1' => [
-            'id' => 'field_1',
-            'value' => 'test-value'
-        ]
+        'field_1' => 'test-value'
     ]);
 
     expect($redirectData)->toBe([