fix: add None guards for device_stats access in sensor lambdas - #284
Open
ahaghshenas wants to merge 2 commits into
Open
fix: add None guards for device_stats access in sensor lambdas#284ahaghshenas wants to merge 2 commits into
ahaghshenas wants to merge 2 commits into
Conversation
device_stats can be None for some devices, causing AttributeError when accessing .statistic_info, .times, .total_time, and .avg_time. Added None checks to all lambdas that access device.device_stats to prevent crashes when device_stats is not populated.
for more information, see https://pre-commit.ci
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sensors crash with
AttributeError: 'NoneType' object has no attribute 'statistic_info'whendevice.device_statsisNone.This affects T3/T4 devices where
device_statsmay not be populated, causing errors in the log and broken sensor entities.Fix
Added
Noneguards to all lambdas that accessdevice.device_stats:device.device_stats.timesdevice.device_stats.total_timedevice.device_stats.avg_timedevice.device_stats.statistic_infoAll now return
Nonewhendevice_statsis not available, instead of crashing.