Add open-in-editor action #319
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a quick-action for opening the current repo in editor. Right now, it is hardcoded to open it in VSCodium, since that is what I have installed, but the next change should make it configurable.
This change adds a setting/preference for the external editor to open all projects with. This change does not yet add per-project editor settings. The setting is also not used anywhere yet.
We now use the editor configured through the app settings to open the repo
We now display an error notification when no editor was set.
The check for whether the editor setting is set was done at the usage site in RepositoryOpenViewModel until now. But this logic could be relevant in other places as well. This change moves it into a new property on the AppSettingsRepository
Previously we used the Kotlin navtive API for starting the process for opening the repo in an external editor. But I just discovered the IShellManager service and assume that it is better to use this. So this change refactores to use that service.
There is now a keybind for opening the repo in an external editor. For now it is set to CTRL+SHIFT+A to match GitHub Desktop
Until now the logic for opening the current repository using an external editor was hosted in the RepositoryOpenViewModel. I noticed that the logic for opening the repo in terminal was hosted in its own use-case object, so this change also introduces such an object for the open-in-editor action
This change adds a global menu button for opening the repo in the configured external editor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements functionality to open the current repository in an external editor. Below are the main changes:
Things that could still be added:
not an editorinto the editor, it will still be saved and only fails once it tries to actually run that command. We then get an ugly error notification with some low-level error details. Would be nice to hide thoseA few notes:
This PR partially resolves #230